Add support to pull NIM profiles from GCS cache #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwschuurman
force-pushed
the
gcs-url-extract-cache
branch
from
a2f7dfa
to
952eafc
Compare
pwschuurman
force-pushed
the
gcs-url-extract-cache
branch
from
952eafc
to
21b70b5
Compare
| @@ -184,17 +229,17 @@ resource "helm_release" "my_nim" { | |||
|
|
|||
| set { | |||
| name = "csi.volumeAttributes.bucketName" | |||
| value = google_storage_bucket.ngc_gcs_cache.name | |||
| value = "ngc-gcs-cache-5f0f6937-fad0-1df7-025e-a912ebf61647" | |||
There was a problem hiding this comment.
Do we mean for this to be a static value? Is there anything significant about this specific bucket?
| if [ -n "${NGC_BUNDLE_URL:-}" ]; then | ||
| # Create a sub-directory, as tar tries to modify the parent folder permissions | ||
| export CACHE_PATH="$NIM_CACHE_PATH/cache" | ||
| mkdir "$CACHE_PATH" |
There was a problem hiding this comment.
Should this be mkdir -p?
|
Would you be able to sign one of your commits prior to accepting this PR? https://github.com/NVIDIA/nim-deploy/blob/main/CONTRIBUTING.MD#signing-your-work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to pull NIM profiles from GCS cache